fix: Move replicate to runtime dependency #3126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xref: conda-forge/opentelemetry-instrumentation-replicate-feedstock#20 https://github.com/traceloop/openllmetry/blob/645426360910ce56d00894fc9c7feb47d5230953/packages/opentelemetry-instrumentation-replicate/opentelemetry/instrumentation/replicate/event_emitter.py#L19 ```raw import: 'opentelemetry.instrumentation.replicate' Traceback (most recent call last): File "/home/conda/feedstock_root/build_artifacts/opentelemetry-instrumentation-replicate_1752448577076/test_tmp/run_test.py", line 2, in <module> import opentelemetry.instrumentation.replicate File "/home/conda/feedstock_root/build_artifacts/opentelemetry-instrumentation-replicate_1752448577076/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/opentelemetry/instrumentation/replicate/__init__.py", line 11, in <module> from opentelemetry.instrumentation.replicate.event_emitter import ( File "/home/conda/feedstock_root/build_artifacts/opentelemetry-instrumentation-replicate_1752448577076/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/opentelemetry/instrumentation/replicate/event_emitter.py", line 19, in <module> from replicate.prediction import Prediction ModuleNotFoundError: No module named 'replicate' ```
|
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 053b35a in 52 seconds. Click for details.
- Reviewed
20lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-replicate/pyproject.toml:27
- Draft comment:
Good move: replicating dependency is now correctly listed as a runtime dependency. Ensure that the version range (>=0.23.1,<0.27.0) is intended. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. packages/opentelemetry-instrumentation-replicate/pyproject.toml:38
- Draft comment:
Removing replicate from the dev dependencies is appropriate now since it's required at runtime. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it states that removing 'replicate' from the dev dependencies is appropriate. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. It simply informs about the appropriateness of the change, which violates the rules.
Workflow ID: wflow_8rIvy0XtIogSGTuW
You can customize 
nirga
reviewed
Jul 14, 2025
| @@ -24,6 +24,7 @@ opentelemetry-api = "^1.28.0" | |||
| opentelemetry-instrumentation = ">=0.50b0" | |||
| opentelemetry-semantic-conventions = ">=0.50b0" | |||
| opentelemetry-semantic-conventions-ai = "0.4.10" | |||
| replicate = ">=0.23.1,<0.27.0" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: conda-forge/opentelemetry-instrumentation-replicate-feedstock#20
openllmetry/packages/opentelemetry-instrumentation-replicate/opentelemetry/instrumentation/replicate/event_emitter.py
Line 19 in 6454263
feat(instrumentation): ...orfix(instrumentation): ....Important
Move
replicateto runtime dependencies inpyproject.tomlto fix import error.replicatefrom[tool.poetry.group.dev.dependencies]to[tool.poetry.dependencies]inpyproject.toml.replicateis available at runtime to preventModuleNotFoundErrorduring import inevent_emitter.py.This description was created by
for 053b35a. You can customize this summary. It will automatically update as commits are pushed.